ignore path dev deps in circular deps check (attempt 2) #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
added
the
automerge
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
* filter out path dev deps in order-crates-for-publishing.py * remove extra backtick * remove debug prints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing what #2471 was trying to do, this time just adding an extra check to filter out path dev deps with no version constraint and leaving
is_self_dev_dep_with_dev_context_only_utilsunchangedI tested this locally by adding
solana-programas a path dev dependency to thesolana-sanitizecrate, and seeing thatorder-crates-for-publishing.pypasses. I then changed it to a workspace dev dep and observed thatorder-crates-for-publishing.pyfailed because of the circular dependency